Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data in jsreport now persists container restart #990

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gpistotnik
Copy link

Corrected in app volume from /jsreport to /app.

First of all, thank you for your contribution! 😄

Please note that this repo is mostly for popular apps with thousands of stars and tens of thousands of downloads. If you'd like to add a less popular app, you can always create your own 3rd party repo and add your app there.

☑️ Self Check before Merge

  • ☑️ I have tested the template using the method described in README.md thoroughly

Fixed bug when reports deleted when restarted.
@githubsaturn
Copy link
Collaborator

githubsaturn commented Oct 4, 2023

Mounting app directory is /jsreport according to their document. Where do you see this new volume?

sudo docker run -p 80:5488 -v /myapp:/jsreport jsreport/jsreport:4.0.0

https://jsreport.net/learn/docker

@githubsaturn
Copy link
Collaborator

Also, it may be just for the newer versions. The default version needs to be updated as well.

@gpistotnik
Copy link
Author

I have version jsreport/jsreport:3.9.0-full and data does not persist if mapped to /jsreport. I have manually checked in container where the report templates are.

@githubsaturn
Copy link
Collaborator

The official docs suggest mapping /app/data - at least for version 4+

image

@gpistotnik
Copy link
Author

Mapping /app/data did not work for me, on existing jsreport container /app/data worked but on new installation it didn't, when I changed to /app - according to log file, it did.

@githubsaturn
Copy link
Collaborator

Interesting! Okay then, let's do this!

@githubsaturn
Copy link
Collaborator

Can you just update the version to the version you tested with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants